Cache the flutter-sdk for testing#4703
Merged
CoderDake merged 55 commits intoflutter:masterfrom Nov 11, 2022
Merged
Conversation
CoderDake
changed the title
CoderDake
commented
Nov 7, 2022
Contributor
Author
|
Talked with Kenzie about this and we are going to try to tighten up the cache usage even more here. |
CoderDake
changed the title
| cd flutter-sdk | ||
| git checkout $LATEST_FLUTTER_CANDIDATE | ||
| env: | ||
| LATEST_FLUTTER_CANDIDATE: ${{ steps.flutter-candidate.outputs.FLUTTER_CANDIDATE }} |
Member
There was a problem hiding this comment.
I see ${{ steps.flutter-candidate.outputs.FLUTTER_CANDIDATE }} being used a few times, are we duplicating this, or in other words can it be put in a local var?
Contributor
Author
There was a problem hiding this comment.
unfortunately I don't think there is a way to make this less verbose.
kenzieschmoll
approved these changes
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates our build.yml workflow so that each of the jobs cache the flutter-sdk and the flutter build artifacts.
For example this is the macos job before the cache is populated
https://github.com/flutter/devtools/actions/runs/3411571892/jobs/5675938782
This is the macos job after the cache is populated
https://github.com/flutter/devtools/actions/runs/3411987066/jobs/5676899259
Details about the cache loading step can be seen in the "Cache Generated Files" step
on the actions page, our caches can be seen:
